OpenAI trace fixes #934
Merged
OpenAI trace fixes #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 1, 2025
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
* Don't create fake parent span, use actual processor base class * Remove print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Build the trace processor out of the more specific base class. Don't create a fake parent span. Add a trace intercepter option for auto closing spans for processors which don't support distributed tracing.
Why?
Puts us in a better place for supporting third party trace processors
Checklist
Closes
How was this tested:
Ran locally with braintrust processor. That still didn't support distributed traces, but this unblocks changes there.
Any docs updates needed?