Making raise on cancellation the default #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 2, 2025
cretz
reviewed
Jul 2, 2025
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
* Making raise on cancellation the default * Lint * Remove todo * Remove code from other feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Set
RAISE_ON_CANCELLING_COMPLETED_ACTIVITYwhen not replaying, and reraise by default.Why?
Prevents the swallowing of some activity cancellations
Checklist
Closes [Bug] Workflow cancellation can be swallowed #620
How was this tested:
Modified tests
Any docs updates needed?