Add heartbeat test and fix bug #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 22, 2025
cretz
reviewed
Jul 22, 2025
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
* Add heartbeat test and fix bug * Reduce intervals for speed * Linting * Skip new test on time skipping server * Update timings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add a test which uses heartbeat timeout. Fix uncaught exception after intentional cancellation of heartbeat task.
Why?
Checklist
Closes Add tests for heartbeating in OpenAI tests #915
How was this tested: