Skip to content

Add argument validation for the types of provided tools #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2025
Merged

Add argument validation for the types of provided tools #985

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6bc3edb
Add argument validation for the types of provided tools
tconley1428 Jul 21, 2025
7b95525
Specifically check if it is a callable, as Union isn't supported in i…
tconley1428 Jul 21, 2025
e4da8aa
Fix type check with typing.get_args
tconley1428 Jul 21, 2025
7ceaa0b
Merge remote-tracking branch 'origin/main' into openai/tool_type_check
tconley1428 Jul 22, 2025
443b2b6
Fix check
tconley1428 Jul 22, 2025
bd83ce2
Merge branch 'main' into openai/tool_type_check
tconley1428 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions temporalio/contrib/openai_agents/_openai_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import typing
from dataclasses import replace
from typing import Any, Union

Expand All @@ -7,6 +8,7 @@
RunResult,
RunResultStreaming,
TContext,
Tool,
TResponseInputItem,
)
from agents.run import DEFAULT_AGENT_RUNNER, DEFAULT_MAX_TURNS, AgentRunner
Expand Down Expand Up @@ -42,6 +44,13 @@ async def run(
**kwargs,
)

tool_types = typing.get_args(Tool)
for t in starting_agent.tools:
if not isinstance(t, tool_types):
raise ValueError(
"Provided tool is not a tool type. If using an activity, make sure to wrap it with openai_agents.workflow.activity_as_tool."
)

context = kwargs.get("context")
max_turns = kwargs.get("max_turns", DEFAULT_MAX_TURNS)
hooks = kwargs.get("hooks")
Expand All @@ -63,16 +72,15 @@ async def run(
),
)

with workflow.unsafe.imports_passed_through():
return await self._runner.run(
starting_agent=starting_agent,
input=input,
context=context,
max_turns=max_turns,
hooks=hooks,
run_config=updated_run_config,
previous_response_id=previous_response_id,
)
return await self._runner.run(
starting_agent=starting_agent,
input=input,
context=context,
max_turns=max_turns,
hooks=hooks,
run_config=updated_run_config,
previous_response_id=previous_response_id,
)

def run_sync(
self,
Expand Down