Skip to content

Use the agent's model name if not present in runconfig #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 25, 2025
Merged

Use the agent's model name if not present in runconfig #996

merged 4 commits into from
Jul 25, 2025

Conversation

tconley1428
Copy link
Contributor

@tconley1428 tconley1428 commented Jul 24, 2025 •
edited
Loading

Thanks to @Anilturaga for #995

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@tconley1428 tconley1428 requested a review from a team as a code owner July 24, 2025 23:16
jssmith
jssmith reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@jssmith jssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good that we are gaining the ability to use the model name set in Agent.

Do we still allow the basic Hello World sample that does not specify a model name anywhere?

@tconley1428
Copy link
Contributor Author

Yes, no change here if they are both None.

@jssmith
Copy link
Contributor

jssmith commented Jul 25, 2025 •
edited
Loading

Do we still allow the basic Hello World sample that does not specify a model name anywhere?

Confirmed, this appears to be working fine.

@tconley1428 tconley1428 merged commit beb9c9d into main Jul 25, 2025
25 of 28 checks passed
@tconley1428 tconley1428 deleted the openai/respect_model_name_in_agent branch July 25, 2025 16:25
@Anilturaga Anilturaga mentioned this pull request Jul 26, 2025
Closed
tconley1428 added a commit that referenced this pull request Aug 28, 2025
@tconley1428
Use the agent's model name if not present in runconfig (#996)
3562003 
* Use the agent's model name if not present in runconfig

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jssmith jssmith jssmith left review comments

@dandavison dandavison dandavison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tconley1428 @jssmith @dandavison