Skip to content

Priority key should be optional #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Priority key should be optional #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e0996
Priority key should be optional
Sushisource Aug 20, 2025
2686da7
Merge branch 'main' into priority-optional
Sushisource Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion temporalio/lib/temporalio/priority.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def self.default
# @param priority_key [Integer, nil] The priority key
# @param fairness_key [String, nil] The fairness key
# @param fairness_weight [Float, nil] The fairness weight
def initialize(priority_key:, fairness_key: nil, fairness_weight: nil)
def initialize(priority_key: nil, fairness_key: nil, fairness_weight: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python doesn't default to None at https://github.com/temporalio/sdk-python/blob/3c6fae6606428bb895c4a0df0c0a9c20c6e4bf82/temporalio/common.py#L985

Copy link
Member Author

@Sushisource Sushisource Aug 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it as well, but we can merge this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporalio/sdk-python#1044

super
end

Expand Down
2 changes: 1 addition & 1 deletion temporalio/sig/temporalio/priority.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Temporalio
attr_reader fairness_key: String?
attr_reader fairness_weight: Float?

def initialize: (priority_key: Integer?, ?fairness_key: String?, ?fairness_weight: Float?) -> void
def initialize: (?priority_key: Integer?, ?fairness_key: String?, ?fairness_weight: Float?) -> void

def self._from_proto: (untyped) -> Priority

Expand Down
Loading