Add within API #53 #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
Jun 12, 2018
README.md
Outdated
| Example: To get the text 'hello' only within a section called 'messages', you could do: | ||
|
|
||
| ```javascript | ||
| import {render, within} from 'react-testing-library' |
There was a problem hiding this comment.
Could you change this example to work better in the dom-testing-library docs?
import {within} from 'dom-testing-library'
const {getByText} = within(document.body.getElementById('messages'))
const helloMessage = getByText('hello')Also, could you add a note that says:
> Fun fact, this is actually just an alias to the `getQueriesForElement` function!
src/index.js
Outdated
| export * from './pretty-dom' | ||
|
|
||
| // The original name of bindElementToQueries was weird | ||
| // The new name is better. Remove this in the next major version bump. |
There was a problem hiding this comment.
Could you move these two comments to right above the bindElementsToQueries export? That's where the comment applies. We'll keep the within alias indefinitely.
sompylasar
reviewed
Jun 12, 2018
| }, | ||
| { | ||
| "login": "Dajust", | ||
| "name": "Justice Mba ", |
There was a problem hiding this comment.
There's an extra space after your name, typo?
There was a problem hiding this comment.
Not sure, I think that file is auto-generated.
There was a problem hiding this comment.
You can fix it manually.
You may want to fix it on GitHub too though 😉
kentcdodds
approved these changes
Jun 12, 2018
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add a
withinAPIWhy: Kindly see #53
How: Exported
getQueriesForElementaswithinfrom the index.js fileChecklist: