feat(queries): allow overriding queries in getQueriesForElement #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkrolick
commented
Jul 9, 2018
| * @param {FuncMap|FuncMap[]} queries object of functions, or array of objects | ||
| * @returns {FuncMap} returns object of functions bound to container | ||
| */ | ||
| function getQueriesForElement(element, queries = defaultQueries) { |
Collaborator
Author
There was a problem hiding this comment.
Note that passing custom queries overrides the default instead of merging. If you want to merge you need to import queries and add it to the array, too.
Open to changing this but I think it makes sense; wrappers like react-testing-library's render can merge queries by default on top of this API if they prefer.
kentcdodds
reviewed
Jul 9, 2018
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Looks good! Just one feature I want removed.
src/get-queries-for-element.js
Outdated
| */ | ||
| function getQueriesForElement(element, queries = defaultQueries) { | ||
| let flattenedQueries | ||
| if (Array.isArray(queries)) { |
Member
There was a problem hiding this comment.
I'd rather not have this logic here. If someone wants to merge the built in queries they can be responsible for doing that themselves when they call the function.
Member
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
alexkrolick
added a commit
to alexkrolick/dom-testing-library
that referenced
this pull request
Sep 13, 2018
* chore: document GitHub issues flow * chore: Link to issues policy * chore: update policies, badges * minor updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
How:
Checklist: