Skip to content

ensure waitForElement responds to attribute and textNode changes by d… #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2018
Merged

ensure waitForElement responds to attribute and textNode changes by d… #74

merged 4 commits into from
Jul 17, 2018

Conversation

@rbrtsmith
Copy link
Collaborator

@rbrtsmith rbrtsmith commented Jul 17, 2018 •
edited
Loading

What:
resolves #72

Why:
Makes for sensible default behaviour - waitForElement will be less confusing to users if it responds to textNode and attribute changes.

How:
Given attributes and characterData default values of true within the mutationObserverOptions config object.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

kentcdodds
kentcdodds approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks!

@kentcdodds kentcdodds merged commit 6e9d7c5 into testing-library:master Jul 17, 2018
@kentcdodds
Copy link
Member

kentcdodds commented Jul 17, 2018

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kentcdodds
Copy link
Member

kentcdodds commented Jul 17, 2018

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexkrolick added a commit to alexkrolick/dom-testing-library that referenced this pull request Sep 13, 2018
@alexkrolick
fix: update getByTestId types (testing-library#74)
851a031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

waitForElement not responding to text-only updates to the markup.

2 participants

@rbrtsmith @kentcdodds