Skip to content

fix: allow console.debug() in no-debug #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2021
Merged

fix: allow console.debug() in no-debug #349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
013df69
fix: allow console.debug() in no-debug
gndelia Apr 20, 2021
eb5748f
refactor: check for built-in console in isDebugUtil
gndelia Apr 20, 2021
268a598
fix: support destructuring from console object
gndelia Apr 20, 2021
1778fa8
fix: no-debug check correctly for declared variable
gndelia Apr 21, 2021
c89f34c
refactor: simplify code
gndelia Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/rules/no-debug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
getReferenceNode,
isObjectPattern,
isProperty,
isMemberExpression,
} from '../node-utils';
import { createTestingLibraryRule } from '../create-testing-library-rule';
import { ASTUtils, TSESTree } from '@typescript-eslint/experimental-utils';
Expand Down Expand Up @@ -50,7 +51,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
}
const initIdentifierNode = getDeepestIdentifierNode(node.init);

if (!initIdentifierNode) {
if (!initIdentifierNode || initIdentifierNode.name === 'console') {
return;
}

Expand Down Expand Up @@ -107,7 +108,11 @@ export default createTestingLibraryRule<Options, MessageIds>({
return;
}

const isDebugUtil = helpers.isDebugUtil(callExpressionIdentifier);
const isDebugUtil =
helpers.isDebugUtil(callExpressionIdentifier) &&
(!isMemberExpression(node.callee) ||
!ASTUtils.isIdentifier(node.callee.object) ||
node.callee.object.name !== 'console');
const isDeclaredDebugVariable = suspiciousDebugVariableNames.includes(
callExpressionIdentifier.name
);
Expand Down
9 changes: 9 additions & 0 deletions tests/lib/rules/no-debug.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ ruleTester.run(RULE_NAME, rule, {
settings: { 'testing-library/utils-module': 'test-utils' },
code: `screen.debug()`,
},
{
code: `console.debug()`,
},
{
code: `
const consoleDebug = console.debug
consoleDebug()
`,
},
{
code: `
const { screen } = require('@testing-library/dom')
Expand Down