Skip to content

fix(flushMicroTasks): Fallback to no scheduler in case of exception #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2020
Merged

fix(flushMicroTasks): Fallback to no scheduler in case of exception #739

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
181b2ee
fix(flushMicroTasks): Fallback to no scheduler in case of exception
MatanBobi Jul 8, 2020
1d8ced0
Merge remote-tracking branch 'upstream/master' into pr/#736-fallback-…
MatanBobi Jul 8, 2020
aa35509
Update src/flush-microtasks.js
kentcdodds Jul 8, 2020
1df3089
Update src/flush-microtasks.js
kentcdodds Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/flush-microtasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ function getIsUsingFakeTimers() {

const globalObj = typeof window === 'undefined' ? global : window
let Scheduler = globalObj.Scheduler
const isModernScheduleCallbackSupported = satisfies(React.version, '>16.8.6', {
includePrerelease: true,
})

let didWarnAboutMessageChannel = false
let enqueueTask
Expand Down Expand Up @@ -58,9 +55,14 @@ try {
'if you encounter this warning.',
)
}

}
}

const isModernScheduleCallbackSupported = Scheduler && satisfies(React.version, '>16.8.6', {
includePrerelease: true,
})

function scheduleCallback(cb) {
const NormalPriority = Scheduler
? Scheduler.NormalPriority || Scheduler.unstable_NormalPriority
Expand Down