Pyo3 and numpy update #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voronaam
commented
Mar 16, 2022
| let dtype: &PyArrayDescr = dtype_obj.cast_as(py).unwrap(); | ||
| let np_dtype = dtype.get_datatype().unwrap(); | ||
| match np_dtype { | ||
| numpy::DataType::Float32 => Ok(Value::from(pyobj_tensor_to_host_tensor::<f32>(py, obj))), |
There was a problem hiding this comment.
This enum was removed as a result of this comment: PyO3/rust-numpy#256 (comment)
Not much of a conversation and/or migration guide. I think I followed the suggested path though, judging by the comments and the changes in that PR.
voronaam
commented
Mar 16, 2022
| numpy::DataType::Uint64 => Ok(Value::from(pyobj_tensor_to_host_tensor::<u64>(py, obj))), | ||
| numpy::DataType::Bool => Ok(Value::from(pyobj_tensor_to_host_bit_tensor(py, obj))), | ||
| match dtype { | ||
| dt if dt.is_equiv_to(numpy::dtype::<f32>(py)) => { |
There was a problem hiding this comment.
Alternatively we can use obj.is_instance_of::<PyArrayDyn<f32>> syntax, but I think this one is a bit better.
There was a problem hiding this comment.
fwiw I also thought is_equiv_to was the right approach, so happy to go with this 👍
mortendahl
approved these changes
Mar 17, 2022
| numpy::DataType::Uint64 => Ok(Value::from(pyobj_tensor_to_host_tensor::<u64>(py, obj))), | ||
| numpy::DataType::Bool => Ok(Value::from(pyobj_tensor_to_host_bit_tensor(py, obj))), | ||
| match dtype { | ||
| dt if dt.is_equiv_to(numpy::dtype::<f32>(py)) => { |
There was a problem hiding this comment.
fwiw I also thought is_equiv_to was the right approach, so happy to go with this 👍
jvmncs
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.