Introduce overrideOptions and progress JSDocs annotations. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@9swampy - Thanks, yes this should be perfect for this ! |
Member
|
@9swampy again, thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to handle #25
No change to existing consumers; continue using only the useDownloader initialisation unaffected, but this PR allows overrideOptions to be specified on the download invocation as well.
await download(DOWNLOAD_ROOT_URI + fileUrl, saveAs, undefined, { method: 'POST' });Works for my scenario, should sort you as well @davecarlson (this is where I was heading on my PR last night anyhow; hope it works for you too - and ofc is acceptable to @olavoparno)