strtotime error

[jakubvojacek]

Hello,

believe there is an issue with default value of $now in strtotime method.

These two are not equal while they should be, I think.

\Safe\strtotime('+ 1 hour') !== strtotime('+ 1 hour')

The default value should be "time()" instead of null

Am I right or is it expected behavior?

Thank you

[jakubvojacek]

This is how I think the strtotime should look like

function strtotime(string $time, int $now = null): int
{
    error_clear_last();
    if ($now === null) {
	    $result = \strtotime($time, time());
    } else {
	    $result = \strtotime($time, $now);
    }
    if ($result === false) {
        throw DatetimeException::createFromPhpError();
    }
    return $result;
}

[moufmouf]

👍

Thanks for the issue. I'll look into it ASAP.
Related to #83 and #85

[moufmouf]

Closed in #85
Actually, there were way more functions impacted. I think I caught them all :)