Handle more PHPStan type edge-cases #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shish
added a commit
to shish/safe
that referenced
this pull request
Dec 2, 2024
After thecodingmachine#486 thecodingmachine#487 and thecodingmachine#488 are merged, running `./.devcontainer/build.sh` produces this output, which contains a couple of years worth of updates - and from there, the github cronjob _should_ submit incremental updates as PRs automatically
This was referenced Dec 2, 2024
Merged
Collaborator
|
per #488 (comment) the tests of this PR should now succeed - as the other 2 dependent PRs have been merged - right ? |
Collaborator
Author
|
@staabm getting close, though it seems I prematurely assumed that all the PHP versions had the same test failures, when actually 8.1 and 8.2-8.4 had different failures >.< But at least the divergence is small enough now, so I'll try to keep the fixes in this PR... |
Collaborator
Author
Collaborator
|
Awesome |
staabm
reviewed
Dec 2, 2024
| $param = new PhpStanType(''); | ||
| $this->assertEquals('', $param->getDocBlockType()); | ||
| $this->assertEquals('', $param->getSignatureType()); | ||
| if (PHP_VERSION_ID >= 80200) { |
Collaborator
There was a problem hiding this comment.
Is this something we need to fix?
Collaborator
Author
There was a problem hiding this comment.
TBH I'm not sure exactly why php8.1 is generating different output here D: It should probably be investigated at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less crashing in code generation \o/