Skip to content

Remove libxml_get_last_error because false is not an error in this case, fixes #438 #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Remove libxml_get_last_error because false is not an error in this case, fixes #438 #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion generated/functionsList.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@
'ldap_sasl_bind',
'ldap_set_option',
'ldap_unbind',
'libxml_get_last_error',
'libxml_set_external_entity_loader',
'link',
'lstat',
Expand Down
19 changes: 0 additions & 19 deletions generated/libxml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,6 @@

use Safe\Exceptions\LibxmlException;

/**
* Retrieve last error from libxml.
*
* @return \LibXMLError Returns a LibXMLError object if there is any error in the
* buffer.
* @throws LibxmlException
*
*/
function libxml_get_last_error(): \LibXMLError
{
error_clear_last();
$safeResult = \libxml_get_last_error();
if ($safeResult === false) {
throw LibxmlException::createFromPhpError();
}
return $safeResult;
}


/**
* Changes the default external entity loader.
* This can be used to suppress the expansion of arbitrary external entities to avoid XXE attacks,
Expand Down
1 change: 1 addition & 0 deletions generator/config/ignoredFunctions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
'apcu_delete', // apcu_delete returns false when the $key does not exist in the cache store
'filter_has_var', // this function is meant to return a boolean
'array_multisort', // this function is too buggy, see PR #113 on GitHub
'libxml_get_last_error', // returns false to mean "everything is fine"
];
1 change: 0 additions & 1 deletion rector-migrate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,6 @@
'ldap_sasl_bind' => 'Safe\ldap_sasl_bind',
'ldap_set_option' => 'Safe\ldap_set_option',
'ldap_unbind' => 'Safe\ldap_unbind',
'libxml_get_last_error' => 'Safe\libxml_get_last_error',
'libxml_set_external_entity_loader' => 'Safe\libxml_set_external_entity_loader',
'link' => 'Safe\link',
'lstat' => 'Safe\lstat',
Expand Down