Skip to content

Fix gmp_random_seed() on PHP 8.1 #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Fix gmp_random_seed() on PHP 8.1 #677

merged 1 commit into from
May 13, 2025

Conversation

@cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne commented May 13, 2025

According to the documentation, since PHP 8.0:

If seed is invalid, gmp_random_seed() now throws a ValueError. Previously it emitted an E_WARNING and returned false.

@OskarStark OskarStark merged commit bb6e2c9 into thecodingmachine:master May 13, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/gmp-random-seed branch May 13, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cedric-anne @OskarStark