Skip to content

Fix sleep() on PHP 8.1 #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Fix sleep() on PHP 8.1 #679

merged 1 commit into from
May 14, 2025

Conversation

@cedric-anne
Copy link
Contributor

@cedric-anne cedric-anne commented May 13, 2025

According to the documentation, since PHP 8.0:

The function throws a ValueError on negative seconds; previously, an E_WARNING was raised instead, and the function returned false.

@silasjoisten
Copy link
Collaborator

silasjoisten commented May 14, 2025

Wow 🤩

@silasjoisten silasjoisten merged commit 9b16dc5 into thecodingmachine:master May 14, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/sleep branch May 14, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cedric-anne @silasjoisten