Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Conversation

Accio1
Copy link
Member

@Accio1 Accio1 commented Aug 31, 2022

Resolves:

Resolves #341

Changes:

  • Add three possible badges to the list of Forum Helpers Page.
    • Dashboard Admin
    • Site Contributor
    • Original Studio Member
    • I decided not to add any badges related to post count, because that is something that may change fairly often and therefore could require a lot of changes. I also wanted to avoid promoting post farming/grinding. If reviewers still think these badges should be added, feel free to say so.
  • The people who should get badges have their badges automatically added after the page loads.
  • Add an expandable legend to the top of the page explaining what each badge is for.
  • To update who gets what badge, the memberData.js file will have to be updated.
    • For now, this is a hardcoded file. In the future, it may be a dashboard feature instead.

Local Tests:

Tested Locally, screenshots attached
On a computer
image

Mobile dimensions
image

@leahcimto @penguinmoose

-Add three possible badges to the list of Forum Helpers Page.
  - Dashboard Admin
  - Site Contributor
  - Original Studio Member
- The people who should get badges have their badges automatically added after the page loads.
- To update who gets what badge, the memberData.js file will have to be updated.
@Accio1 Accio1 added the pr - status: unreviewed PR has not been reviewed yet label Aug 31, 2022
@Accio1 Accio1 requested a review from leahcimto August 31, 2022 00:38
Copy link
Contributor

@leahcimto leahcimto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@leahcimto leahcimto assigned Accio1 and unassigned leahcimto Aug 31, 2022
@leahcimto
Copy link
Contributor

Also, @Accio1 I was adding some dashboard things and was wondering if you could rename wangat to KangaCoder? Thanks

@leahcimto leahcimto added pr - status: approved Good to merge and removed pr - status: unreviewed PR has not been reviewed yet labels Aug 31, 2022
@Accio1
Copy link
Member Author

Accio1 commented Sep 1, 2022

Also, @Accio1 I was adding some dashboard things and was wondering if you could rename wangat to KangaCoder? Thanks

Done. In the future if I'm not active or whatever you can achieve the same result by removing the user with the original name and then adding another user with the new name. It should be a fairly rare occurrence though because of how infrequently username changes occur on scratch.

@leahcimto
Copy link
Contributor

Also, @Accio1 I was adding some dashboard things and was wondering if you could rename wangat to KangaCoder? Thanks

Done. In the future if I'm not active or whatever you can achieve the same result by removing the user with the original name and then adding another user with the new name. It should be a fairly rare occurrence though because of how infrequently username changes occur on scratch.

I'm pretty sure though that would move the user to the bottom of the list though?

@Accio1
Copy link
Member Author

Accio1 commented Sep 2, 2022

Also, @Accio1 I was adding some dashboard things and was wondering if you could rename wangat to KangaCoder? Thanks

Done. In the future if I'm not active or whatever you can achieve the same result by removing the user with the original name and then adding another user with the new name. It should be a fairly rare occurrence though because of how infrequently username changes occur on scratch.

I'm pretty sure though that would move the user to the bottom of the list though?

Right, I hadn't considered that. It's such a rare occurrence that I don't mind just directly editing the database when it occurs since adding a username change option to the dashboard would be a bit of a hassle.

Copy link
Contributor

@penguinmoose penguinmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Accio1 Accio1 merged commit 104d970 into master Sep 4, 2022
@Accio1 Accio1 deleted the Badges branch September 4, 2022 17:01
badgeBlock.innerHTML = badgeBlock.innerHTML + '<img src="../resources/admin.png" class="memberBadge" width="32px" height="32px" title="Dashboard Admin">';
}
if (memberSiteContributor.includes(name)) {
badgeBlock.innerHTML = badgeBlock.innerHTML + '<img src="../resources/coder.png" class="memberBadge" width="32px" height="32px" title="Site Contributer">';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site Contributer

typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#361 created

leahcimto added a commit that referenced this pull request Sep 5, 2022
@leahcimto leahcimto mentioned this pull request Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Website Contributor Icons/Emojis

4 participants