Skip to content

Conversation

@Anavelyz
Copy link
Contributor

@Anavelyz Anavelyz commented Nov 29, 2022

Description

  • Fix DataFrame word in the docstrings
  • Improving the docstrings

Related Issue

#197

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've used pre-commit hook locally.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • Semantic-release prefix title used (case sensitive):
    • Use the prefix chore(docs): for Examples / docs / tutorials / dependencies update
    • Use the prefix fix: for a bug fix
      (non-breaking change which fixes an issue).
    • Use the prefix chore(improvement): for an improvement
      (non-breaking change which improves an existing feature).
    • Use the prefix feat: for a new feature
      (non-breaking change which adds functionality).
    • Use the prefix BREAKING CHANGE: for a breaking change
      (fix or feature that would cause existing functionality to change).
    • Use the prefix chore(security): for a security fix.

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read it in details, but in general it looks good to me.
@eduardocorrearaujo could you review this one by chance? thanks

@github-actions
Copy link

Stale pull request message

@xmnlab
Copy link
Member

xmnlab commented Mar 15, 2023

I think we probably should try to move this forward.

@Anavelyz
Copy link
Contributor Author

Anavelyz commented Mar 17, 2023

@xmnlab What should I do to help with this?

@xmnlab xmnlab reopened this Mar 21, 2023
@xmnlab
Copy link
Member

xmnlab commented Mar 21, 2023

@Anavelyz could you please fix the issues that are occurring on CI, please?

@xmnlab
Copy link
Member

xmnlab commented Mar 25, 2023

@Anavelyz have you closed this on purpose?

@Anavelyz Anavelyz reopened this Mar 25, 2023
@Anavelyz
Copy link
Contributor Author

@Anavelyz have you closed this on purpose?

No, I was trying to do a fetch and deleted the commits, then git didn't see any changes so it closed

This file has a different documentation style, should it be changed?
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anavelyz for working on that. In general looks good. Just noted that some docstrings are not in the numpydocs standard. Could you move that docstrings to numpydics too please? Thanks!!

@Anavelyz
Copy link
Contributor Author

Thanks @Anavelyz for working on that. In general looks good. Just noted that some docstrings are not in the numpydocs standard. Could you move that docstrings to numpydics too please? Thanks!!

Ready!

@Anavelyz Anavelyz requested a review from xmnlab May 3, 2023 19:52
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small comment inline.
please fix that and ping me again and we can merge this pr.
thanks!

@Anavelyz Anavelyz requested a review from xmnlab May 4, 2023 21:55
Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that

@xmnlab xmnlab merged commit eed7771 into thegraphnetwork:main May 5, 2023
@Anavelyz Anavelyz deleted the doc branch May 11, 2023 02:30
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants