-
Notifications
You must be signed in to change notification settings - Fork 9
chore(docs): Improve docstrings #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xmnlab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read it in details, but in general it looks good to me.
@eduardocorrearaujo could you review this one by chance? thanks
|
Stale pull request message |
|
I think we probably should try to move this forward. |
|
@xmnlab What should I do to help with this? |
|
@Anavelyz could you please fix the issues that are occurring on CI, please? |
|
@Anavelyz have you closed this on purpose? |
No, I was trying to do a fetch and deleted the commits, then git didn't see any changes so it closed |
This file has a different documentation style, should it be changed?
xmnlab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Anavelyz for working on that. In general looks good. Just noted that some docstrings are not in the numpydocs standard. Could you move that docstrings to numpydics too please? Thanks!!
Ready! |
xmnlab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one small comment inline.
please fix that and ping me again and we can merge this pr.
thanks!
xmnlab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for working on that
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Related Issue
#197
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.chore(docs):for Examples / docs / tutorials / dependencies updatefix:for a bug fix(non-breaking change which fixes an issue).
chore(improvement):for an improvement(non-breaking change which improves an existing feature).
feat:for a new feature(non-breaking change which adds functionality).
BREAKING CHANGE:for a breaking change(fix or feature that would cause existing functionality to change).
chore(security):for a security fix.