-
Notifications
You must be signed in to change notification settings - Fork 36
Fix repeated suffixes #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 588b7e4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the header files and confirmed that the signatures in api.json are generated as expected.
How Has This Been Tested?
I've copied api.json to my local splashkit.io-starlight repo for testing:
- Tested in latest Chrome
- Tested in latest Firefox
- npm run build
- npm run preview

Confirmed the new signatures showed up when including the relevant files:
-
splashkit.py
:
def quad_from_line(line_origin, line_end, width):
def draw_bitmap_on_bitmap(destination, bmp, x, y):
def draw_bitmap_on_bitmap_with_options(destination, bmp, x, y, opts):
def set_interface_font_with_string(fnt):
def vector_from_center_sprite_to_point(s, pt):
-
SplashKit.cs
:
public bool Bitmap.PixelDrawnAtPoint(Point2D pt);
public Vector2D Sprite.VectorFromCenterToPoint(Point2D pt);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR and checked locally as well. I concur with dijidiji that api.json are generated as expected.
I approve this PR
Description
Below are the names of some functions in the Python or C# implementation of the Splashkit library that obviously have issues (ie. repeated words and substrings).
I have fixed the issue by navigating to each header file containing the function declaration and modifying the suffix attribute in the header docs. In most cases, this involved removing a substring from the suffix that was already in the function’s base name and therefore, didn’t need to be added again in the suffix.
Type of change
How Has This Been Tested?
This was tested by running the translator and checking the api.json file to see if the correct function signatures were being generated.
To verify this pull request, you can do the same by going through the commit history and finding the commit named "Generate Files". I have reverted this commit because I don't want it included when this PR finally gets merged but I have left a commit so you don't have to run the translator yourself.
Testing Checklist
Checklist