Add resource bundle unit tests and fix bug in free_resource_bundle #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts Andrew Cain's resource bundle tests from sktest for skunit_tests. They were a good candidate for unit tests since it's simple to confirm the loading and unloading of resources.
Also fixes an issue discovered when porting these tests over:
When loading, the
IMAGE_RESOURCE
case had the following check:if ( ! has_resource_bundle(line_name) ) return;
This would always return (because it was checking resource bundles
rather than bitmaps), bitmaps to be loaded but never be added to
the list of bundled resources.
This in turn resulted in free_resource_bundle never freeing that resource.
Type of change
How Has This Been Tested?
Testing Checklist
Ran both test executables to ensure the tests functioned the same way and made sure the output was as expected after the bug fix (bitmaps successfully unloaded).
Checklist