Solidity 0.8.17 #3318
Merged
Solidity 0.8.17 #3318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version has solidity pragma fixed to 0.8.17.
We still need 0.8.9 compiler to compile contracts from @threshold-network/solidity-contracts so instead of replacing 0.8.9 with 0.8.17 we have them both.
The dependency has been updated to the most recent version with a floating pragma on IStaking and IApplication interfaces. This will allow to compile random beacon contracts with 0.8.17 compiler.
After the update to 0.8.17 compiler, the gas cost is a bit smaller. Since the difference is not that significant and it is only one path that reports the problem, I decided to tweak the assertion instead of revisiting offsets.
pdyraga
requested review from
dimpar,
lukasz-zimnoch,
nkuba and
tomaszslabon
as code owners
nkuba
approved these changes
Sep 28, 2022
70 tasks
This was referenced Sep 28, 2022
Merged
nkuba
added a commit
to threshold-network/tbtc-v2
that referenced
this pull request
Sep 28, 2022
Solidity 0.8.17 See keep-network/sortition-pools#189 See threshold-network/solidity-contracts#127 See threshold-network/keep-core#3318 See threshold-network/keep-core#3319 Fix Solidity version on 0.8.17 before the deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on threshold-network/solidity-contracts#127
See keep-network/sortition-pools#189
Fix Solidity version on 0.8.17 before the deployment.