Added minimumAuthorization function to IApplication interface #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygnusv
previously approved these changes
Apr 21, 2022
contracts/staking/IApplication.sol
Outdated
| /// authorized amount for the given staking provider increased. | ||
| /// The application may do any necessary housekeeping. | ||
| /// The application may do any necessary housekeeping. The | ||
| /// application may revert the transaction in case the authorization |
There was a problem hiding this comment.
Suggested change
| /// application may revert the transaction in case the authorization | |
| /// application must revert the transaction in case the authorization |
Otherwise, it doesn't make much sense to define it as a "minimum authorization"
There was a problem hiding this comment.
Makes sense! Updated in the last commit.
There was a problem hiding this comment.
Code format is complaining but I'll fix it once #87 is merged when rebasing over main. Ignoring for now.
vzotova
previously approved these changes
Apr 22, 2022
There is an implicit contract in TokenStaking that IApplication may revert in case the minimum authorization requirement is not met. The problem is that IApplication does not clearly define what is the minimum authorization. This change improves it. First, the contract about `increaseAuthorization` reverting if the minimum requirement is not met is now explicit. Second, `IApplication` exposes `minimumAuthorization` information.
Application *must* revert increaseAuthorization in case the minimum required authorization is not satisfied.
|
#87 got merged so I am rebasing this PR over |
|
System tests are failing because of a Hardhat problem described here #87 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #88
Refs threshold-network/keep-core#2935
Depends on #87 (keeping as a draft until #87 is merged)There is an implicit contract in
TokenStakingthatIApplicationmayrevert in case the minimum authorization requirement is not met. The
problem is that
IApplicationdoes not clearly define what is the minimumauthorization.
This change improves it. First, the contract about
increaseAuthorizationreverting if the minimum requirement is not metis now explicit. Second,
IApplicationexposesminimumAuthorizationinformation.