Ensure that rows_*() preserves the type of x
#6240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also ensures that we only use data frame operations that we have documented that we use internally. Specifically, this avoids `df[i, j]` (and its assignment variant) which suffers from `drop = FALSE` issues with bare data frames. It is replaced with usage of `df[i]`, `dplyr_row_slice()`, and `dplyr_col_modify()`. Tests have been added to ensure that we never regress here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also ensures that we only use data frame operations that we have documented that we use internally. Specifically, this avoids
df[i, j](and its assignment variant) which suffers fromdrop = FALSEissues with bare data frames. It is replaced with usage ofdf[i],dplyr_row_slice(), anddplyr_col_modify(). Tests have been added to ensure that we never regress here.Preserving the column types in
xwas something that we already document, but this wasn't actually occurring correctly. Instead, we often ended up taking the common type (especially with bare data frames).