-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Create quosures in tally_n()
#7046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@krlmlr do you still use this feature in duckplyr? Would switching to |
|
|
|
So to be super clear, instead of |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Should be good now. |
|
Great thanks! |
Recent duckplyr checks that all functions used in a dplyr verb are what they pretend they are: tidyverse/duckplyr#179. This works for most cases, except for the
n()created bytally_n(). This PR fixes this.Once we agree on the implementation, I can vendor in a copy of this function into duckplyr.