Remove circular dependency between apiserver and authentication #3761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rene-dekker
force-pushed
the
TSLA-8741
branch
from
c108ebe to
d903b87
Compare
tmjd
reviewed
Feb 5, 2025
| secret := render.DexTLSSecretName | ||
| certificate, err := certificateManager.GetCertificate(r.client, secret, common.OperatorNamespace()) | ||
| if authenticationCR != nil && authenticationCR.Status.State == operatorv1.TigeraStatusReady { | ||
| if !utils.IsDexDisabled(authenticationCR) { |
There was a problem hiding this comment.
Would you mind adding a utils.IsDexEnabled function and remove this double negative (negating isDisabled)?
There was a problem hiding this comment.
Added a commit. Much better, I can't stand it either ;)
rene-dekker
force-pushed
the
TSLA-8741
branch
from
58975f4 to
e7d4a42
Compare
|
/merge-when-ready delete-branch |
|
OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and delete the branch after I've merged it. |
|
I'm sorry but I failed delete the branch after merging the pull request. |
marvin-tigera
added a commit
that referenced
this pull request
Feb 6, 2025
…761-origin-release-v1.37 Automated cherry pick of #3761: Remove circular dependency between apiserver and
This was referenced Mar 27, 2025
Merged
rene-dekker
added a commit
that referenced
this pull request
Mar 28, 2025
…iserver and (#3841) * Remove circular dependency between apiserver and authentication * Remove double negations by turning IsDexDisabled into DexEnabled * Fix copyright headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.