Skip to content

[RS-2418] Add ComponentWAFHTTPFilter to EnterpriseImages #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gantony
Copy link
Contributor

@gantony gantony commented May 21, 2025

Description

This was missing in #3949.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@gantony gantony changed the title [RS-2418] Add ComponentWafHTTPFilter to EnterpriseImages [RS-2418] Add ComponentWAFHTTPFilter to EnterpriseImages May 21, 2025
@@ -164,7 +164,7 @@ var (
}
{{- end }}
{{ with index .Components "waf-http-filter" }}
ComponentWafHTTPFilter = Component{
ComponentWAFHTTPFilter = Component{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using this component somewhere? I think There should be a corresponding rename where this component is being used.

@radTuti radTuti modified the milestones: v1.39.0, v1.40.0 Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants