Parse group DMs #118
Parse group DMs #118
Conversation
…roducible, deterministic filenames)
…ation (for group dms)
…in markdown output
|
I don't have any group DMs to test this on, so I'm hoping you do. There must be duplicated code between this and #116? I haven't gone over it in enough detail to confirm. |
Yes, I have :) And I tested it on my own group DMs many times while building this. (Of course, I could always have overlooked some bug, but overall it seems to work fine.)
The format of group DMs and 'single' DMs in the JSON is slightly different, but I'm sure there is some duplicate code in here, yes. If you think that would be useful, I could look into it and see if any parts could be extracted and used in both? |
# Conflicts: # parser.py
lenaschimmel
left a comment
lenaschimmel
left a comment
There was a problem hiding this comment.
Approving this as discussed yesterday.
3 participants
Parsing of direct-messages-group.js and writing to one markdown file per group (splitting up very long ones into parts).
Image embedding (and copying, etc.) is still missing here, I will add that (probably) tomorrow.Image embedding is now also implemented here (at the same level of completion as for the non-group DMs in #116).