tinygo: detect GOOS=wasip1 for relative WASI paths via config #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgryski
approved these changes
Aug 21, 2024
Member
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
Approving for now to fix CI issues, but a better fix exists.
Member
|
Is this fix urgent enough to justify a patch release? |
aykevl
reviewed
Aug 21, 2024
Member
There was a problem hiding this comment.
Optionsis what is passed on the command line or via environment variables.Targetis what is loaded from targets/*.json (or constructed at runtime for Linux/MacOS/Windows and some wasm targets).
A cleaner fix would be to use config.GOOS(). The Config struct is the one source of truth given the two inputs which might conflict. (And in this case, it just returns config.Target.GOOS so the fix is correct).
Contributor
Author
|
I'll make a new PR that uses that API. I think I want to understand the differences between wasip1 and wasip2 w/r/t directories, Cwd, etc. Will talk with @dgryski to understand. I think post second patch it's worth shipping a new release. |
Member
OK, sounds like a plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes running tests without
-target=wasip1, e.g.:GOOS=wasip1 GOARCH=wasm tinygo test ./...