Skip to content

Conversation

@Aschen
Copy link

@Aschen Aschen commented May 28, 2020

What does this PR do

Remove files needed to compile native add-ons (.cpp, .h, .o etc)
Remove the package-lock.json since it's not needed anymore after installing dependencies.
Remove man directory (man pages), features (cucumber) and .git

@Aschen
Copy link
Author

Aschen commented Jun 19, 2020

@tj Sorry to ask, but are you still maintaining the repo? Do you want some help?

".appveyor.yml",
"tsconfig.json",
"tslint.json",
"package-lock.json",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tsconfig.json",
"tslint.json",
"package-lock.json",
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you remove closing bracket

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My laziness is damn too high 😅

@zzjin
Copy link

zzjin commented Aug 26, 2021

I've add man and .git to ignore folders, and IMO file exts can set by --include *.h --include *.c, so I don't use it to my pr: #73. Checkout and have a try~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants