Skip to content

Move loom to dev-dependencies #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

Move loom to dev-dependencies #416

merged 1 commit into from
Jul 13, 2020

Conversation

@seanmonstar
Copy link
Member

@seanmonstar seanmonstar commented Jul 13, 2020

Closes #411 #400

@seanmonstar seanmonstar requested a review from carllerche July 13, 2020 23:38
@hawkw
Copy link
Member

hawkw commented Jul 13, 2020

I think that this might mean that RUSTFLAGS="--cfg loom" cargo build will fail. I don't know if that matters to us.

@seanmonstar
Copy link
Member Author

seanmonstar commented Jul 13, 2020

I don't think it does.

@seanmonstar seanmonstar merged commit 025bec2 into master Jul 13, 2020
@seanmonstar seanmonstar deleted the loom-dev-dep branch July 13, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hawkw hawkw hawkw approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

loom dependency pulled in by default

3 participants

@seanmonstar @hawkw