Skip to content

Conversation

@braddunbar
Copy link
Contributor

CI is failing due to unused_imports because Iterator is already in the prelude. Removing it fixes things up.

error: the item `Iterator` is imported redundantly
  --> src/bytes_mut.rs:1:32
   |
1  | use core::iter::{FromIterator, Iterator};
   |                                ^^^^^^^^
   |
  ::: /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/prelude/mod.rs:28:13
   |
28 |     pub use super::v1::*;
   |             --------- the item `Iterator` is already defined here
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

CI is [failing][failure] due to unused_imports because Iterator is
already in the prelude. Removing it fixes things up.

[failure]: https://github.com/tokio-rs/bytes/actions/runs/8034858583/job/21946873895
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 99584cc into tokio-rs:master Mar 2, 2024
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
@braddunbar braddunbar deleted the prelude-iterator branch March 24, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants