Skip to content

Conversation

0xPoe
Copy link
Collaborator

@0xPoe 0xPoe commented Jan 18, 2023

cargo clippy to see:

warning: the borrowed expression implements the required traits
  --> xtask/src/main.rs:77:18
   |
77 |         .out_dir(&out_dir)
   |                  ^^^^^^^^ help: change this to: `out_dir`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

warning: `xtask` (bin "xtask") generated 1 warning
    Checking tokio-console v0.1.7 (/Users/hi-rustin/vsc/console/tokio-console)
    Checking console-subscriber v0.1.8 (/Users/hi-rustin/vsc/console/console-subscriber)
warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> console-subscriber/src/stats.rs:315:18
    |
315 |             Some(id as u64)
    |                  ^^^^^^^^^ help: try: `id`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: `console-subscriber` (lib) generated 1 warning

Signed-off-by: hi-rustin <[email protected]>
@0xPoe 0xPoe requested a review from a team as a code owner January 18, 2023 14:12
@hawkw hawkw enabled auto-merge (squash) January 18, 2023 17:14
@hawkw hawkw merged commit 300bd93 into tokio-rs:main Jan 18, 2023
hawkw pushed a commit that referenced this pull request Sep 29, 2023
Signed-off-by: hi-rustin <[email protected]>

Signed-off-by: hi-rustin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants