Fix backward-compatibility of nn.View #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@soumith How about adding a backward-compatibility test? Travis could download an example network from somewhere and try to load and run one forward and backward pass through it. |
Member
|
i like that idea. Who is up for creating an insane model that uses like almost all of nn modules, that should be fun. |
soumith
added a commit
that referenced
this pull request
Mar 15, 2016
Fix backward-compatibility of nn.View
Contributor
Author
|
@soumith I can do that. I first though of a frankenstein network, but then I realised that it would be enough to test each module separately haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues from #712