Add torrent title to torrent details page URL #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you click on the torrent list you are redirected to: http://localhost:3000/torrent/0c90fbf036e28370c1ec773401bc7620146b1d48/test1 including the torrent title at the end of the URL in a new URL segment.
For example, this torrent title: ` test--test-&-123 test ` would use this URL: http://localhost:3000/torrent/1fc73eb95330bb80251f3fd3b96d1dfd120e81ec/test-test-123-test Notice the title ` test--test-&-123 test ` has been converted to `test-test-123-test`
The component for the torrent details was ducplicated for the two URLs: - http://localhost:3000/torrent/1fc73eb95330bb80251f3fd3b96d1dfd120e81ec/test-test-123-test - http://localhost:3000/torrent/1fc73eb95330bb80251f3fd3b96d1dfd120e81ec Depending on whether you use the "slug" with the title or not.
Being a torrent title `Sample Title` Both torrent detail pages (with or without title slug): - http://localhost:3000/torrent/1fc73eb95330bb80251f3fd3b96d1dfd120e81ec - http://localhost:3000/torrent/1fc73eb95330bb80251f3fd3b96d1dfd120e81ec/sample-title have now the HTML title meta tag: `Sample Title - Torrent`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you click on the torrent list, you are redirected to:
http://localhost:3000/torrent/0c90fbf036e28370c1ec773401bc7620146b1d48
We wanted to add the torrent title to the URL to improve SEO.
http://localhost:3000/torrent/0c90fbf036e28370c1ec773401bc7620146b1d48/test1
This is only one proposal. I've added some alternatives in the issue 102
TODO:
titletag.