Show torrent comment on torrent details page #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
approved these changes
Oct 5, 2023
|
Hi @mario-nt it looks good. If you change the commit message I can merge it. |
Nice, once we update the types and API lib packages on NPM, I will update the package.json file and write the final commit message so you can merge the PR. |
Hi @mario-nt, I've done it. I've published the |
Details page of a torrent now displays the comment field if exists. Updated libraries packages for API responses to contain the comment field.
mario-nt
force-pushed
the
#277-show-torrent-comment-on-torrent-details-page
branch
from
29379b5 to
ce5bd32
Compare
|
Updated dependencies and tests OK, ready for review and merging. @josecelano |
josecelano
approved these changes
Oct 7, 2023
|
ACK ce5bd32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #277.