Show error when proxied image cannot be loaded #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'll be used to show errors when a proxied image can't be loaded for some reason: - Proxy not available or with wonrg configuration. - Image extension not allowed.
cant' be loaded becuse: - The image proxy returns an error. - The image extension is not allowed.
|
ACK e578718 |
josecelano
deleted the
409-show-error-when-proxied-image-cannot-be-loaded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error is an image with a text explaining the error. The reason is I don't want the sanitizer to inject other elements into the DOM. The sanitizer replaces images
imgwith proxied images (images from the proxy the Index API).The current behavior when the proxy does not work or the extension is not valid is just not showing the image. This PR generates an error image in those cases. The same way browsers show "broken images" when they can load images.