fix:[#525] more efficient solution #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
previously approved these changes
Apr 23, 2024
josecelano
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Hi @ngthhu,
Looks good, but you need to rebase it. Also there is a linter error:
WARN warning: 11:27:59 AM
/home/josecelano/Documents/git/committer/me/github/torrust/torrust-index-gui/components/Markdown.vue
3:85 warning Expected a space before '/>', but not found vue/html-closing-bracket-spacing
✖ 1 problem (0 errors, 1 warning)
0 errors and 1 warning potentially fixable with the --fix option.
Plugin: vite-plugin-eslint
File: /home/josecelano/Documents/git/committer/me/github/torrust/torrust-index-gui/components/Markdown.vue?vue&type=style&index=0&scoped=d6e6bce6&lang.css
This is the patch:
- <div class="prose max-w-none text-justify word-wrap" v-html="sanitizedDescription"/>
+ <div class="prose text-justify max-w-none word-wrap" v-html="sanitizedDescription" />
The testing workflow should fail here. The linter is failing but the workflow is not. I will open a new issue for that.
You can run the linter locally before committing with:
npm run lintOr
npm run lintfixTo fix issues that can be fixed automatically.
|
The workflow was not failing because it was only a warning. But I would prefer to make it fail for warnings, too. |
fix:[torrust#525] custom word-wrap css class lint fix
hungfnt
force-pushed
the
fix-text-overflow-2
branch
from
b043864 to
11478f9
Compare
|
ACK 585447a |
josecelano
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.