Skip to content

Conversation

@hungfnt
Copy link
Contributor

@hungfnt hungfnt commented Apr 27, 2024

I'm not able to test it.

@josecelano josecelano added the Needs Rebase Base Branch has Incompatibilities label Apr 27, 2024
@josecelano josecelano linked an issue Apr 27, 2024 that may be closed by this pull request
@josecelano
Copy link
Member

Hi @ngthhu I normally test these things with npm run lint && echo "OK".

If you see the "OK", the previous command didn't return an error code. ESLint returns an error with the new option.

npm run lint && echo "OK"

> lint
> eslint --ext ".ts,.js,.vue" . --max-warnings=0

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.4.3

Please only submit bug reports when using the officially supported version.

=============

/home/josecelano/Documents/git/committer/me/github/torrust/torrust-index-gui/components/Breadcrumb.vue
  9:56  warning  Expected no space before '>', but found  vue/html-closing-bracket-spacing

✖ 1 problem (0 errors, 1 warning)
  0 errors and 1 warning potentially fixable with the `--fix` option.

ESLint found too many warnings (maximum: 0).

@josecelano
Copy link
Member

ACK 2251ba0

@josecelano
Copy link
Member

Another suggestion. We usually prefer rebasing rather than merging. In other projects, we force a linear history.

@josecelano josecelano merged commit eb1d504 into torrust:develop Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Rebase Base Branch has Incompatibilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing workflow is not failing when the linter throws a warning

2 participants