Fix bug in tags and categories filters #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Going back with the browser button in the torrent list page produces an URL with a param like this "tagFilters=os" when the previous filters only contain sone item. That can be interpreted as a flat option or an array with one element. The application was applying the first option and the index-api-lib package expects the tagFilters to be always an array of strings. Same for categoryFilters. This only happended using the "back" buttom.
josecelano
force-pushed
the
601-ttagsjoin-bug
branch
from
94a07e0 to
549ad56
Compare
|
ACK 549ad56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going back with the browser button in the torrent list page produces an URL with a param like this "tagFilters=os" when the previous filters only contain sone item.
That can be interpreted as a flat option or an array with one element.
The application was applying the first option and the index-api-lib package expects the tagFilters to be always an array of strings.
Same for
categoryFilters.This only happended using the "back" buttom.