47f5242 chore: fix comment (Jose Celano) 3d3fc2d chore: add todo to seeder (Jose Celano) 2fc2016 refactor: [#472] move unwraps from API client up (Jose Celano) 1015945 chore: remove comment (Jose Celano) 564df07 docs: move comment (Jose Celano) a8c2f84 refactor: [#472] move unwraps from generic HTTP client up to Index API client (Jose Celano) 26422fc feat: [#472] add timeout to API client requests (Jose Celano) 9ff4de4 feat: [#472] inject URL scheme in API client (Jose Celano) 2cf5f47 refactor: [#472] move generic HTTP client (Jose Celano) Pull request description: The API client does not have any timeout. The client waits indefinitely for responses. That should not be the default behaviour. It should return an error after a timeout. The users using the client should handle the timeout or any other error. ### Subtasks - [x] Move generic HTTP client to HTTP mod. - [x] Generic HTTP client: Inject the scheme part of the URL in the constructor. - [x] Add timeouts to the generic HTTP client. - [x] Remove `unwraps` from the generic HTTP client. Return errors. - [x] Remove `unwraps` from the Index API HTTP client. Return errors. ACKs for top commit: josecelano: ACK 47f5242 Tree-SHA512: 59cc901b58c19aff0f5258a5297d722389beb9d1ac38838fc470e9cc3e2159abc594cb05db7c1403e2111477149c1834a68f182425cbc101bc0c29c2d0b76613

Index API client: add timeout to requests #472

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions