Refactor TrackerService to improve app testability
#145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for listing torrents was failing becuase the uploaded torrents was not in the result. Since we added a pagination limit in this PR: #142 Now it can happen that the torrent you've just uploaded is not in the response, because tests run in paralell. When we will able to run this test mocking the `TrackerService` we couuld run it with an isolated environment, so the expected result if always only one torrent. Then we could check that the torrent is on the list again.
josecelano
changed the title
TrackerServiceTrackerService to improve app testability
Instead of using the API client directly. TrackerService is easier to mock becuase you only need to build simple app structs instead of reqwest responses.
|
ACK 404caee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These refactorings will allow writing tests that require a mock for the
TrackerService.