Enable pedantic clippy on CI

[josecelano]

Enable pedantic clippy on CI.

[josecelano]

Hi @da2ce7, I do not know why we get some extra errors. I'm using exactly the same toolchain but I do not get any error:

Runner:

rustc +nightly --version --verbose
rustc 1.71.0-nightly (2f6bc5d25 2023-05-09)
binary: rustc
commit-hash: 2f6bc5d259e7ab25ddfdd33de53b892770218918
commit-date: 2023-05-09
host: x86_64-unknown-linux-gnu
release: 1.71.0-nightly
LLVM version: 16.0.2

Mine:

$ rustc +nightly --version --verbose
rustc 1.71.0-nightly (2f6bc5d25 2023-05-09)
binary: rustc
commit-hash: 2f6bc5d259e7ab25ddfdd33de53b892770218918
commit-date: 2023-05-09
host: x86_64-unknown-linux-gnu
release: 1.71.0-nightly
LLVM version: 16.0.2

I've tried a cargo clean. Maybe it's not the same clippy version.

Mine:

clippy 0.1.71 (2f6bc5d 2023-05-09)

[josecelano]

I'm using the same version, so no idea why we are getting errors on the runner and not on my local machine.

[josecelano]

Hi @da2ce7 @WarmBeer, after debugging for a long time, I found out that I can get the same error locally with the following:

CARGO_INCREMENTAL=0 cargo clippy --all-targets -- -D clippy::pedantic

For some reason, clippy does not show those errors if incremental compilation is enabled.