Skip to content

76 add tags to torrents #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2023
Merged

76 add tags to torrents #162

merged 5 commits into from
Jun 9, 2023

Conversation

@mickvandijke
Copy link
Member

@mickvandijke mickvandijke commented May 24, 2023

No description provided.

@josecelano josecelano mentioned this pull request May 25, 2023
Merged
6 tasks
@josecelano josecelano added the Needs Rebase Base Branch has Incompatibilities label Jun 5, 2023
@josecelano josecelano linked an issue Jun 6, 2023 that may be closed by this pull request
Add tags to torrents #76
Closed
@josecelano josecelano mentioned this pull request Jun 8, 2023
Closed
@mickvandijke mickvandijke marked this pull request as ready for review June 9, 2023 07:26
@mickvandijke mickvandijke requested review from da2ce7 and josecelano June 9, 2023 07:26
@josecelano
Copy link
Member

josecelano commented Jun 9, 2023

ACK 4730afd

@mickvandijke mickvandijke merged commit e766b4c into develop Jun 9, 2023
@josecelano
Copy link
Member

josecelano commented Jun 9, 2023

Hi @WarmBeer, I've just realized only the admin can create new tags. Is that intentional behaviour? I would have expected every user to create their own tags when they upload a new torrent.

@josecelano
Copy link
Member

josecelano commented Jun 9, 2023

Hi @WarmBeer, I've just realized only the admin can create new tags. Is that intentional behaviour? I would have expected every user to create their own tags when they upload a new torrent.

And it also allows adding duplicate tags (tags with the same name).

@josecelano
Copy link
Member

josecelano commented Jun 9, 2023

And there were some broken E2E tests: https://github.com/torrust/torrust-index-backend/actions/runs/5209788950/jobs/9400067460#step:13:1319, but the workflow did not fail. I'm going to open a new issue to find out why the workflow is not failing when an E2E test fails.

In this case, I suppose the changes in SQL queries to include tags make some queries fail.

This was referenced Jun 9, 2023
Closed
Closed
@josecelano
Copy link
Member

josecelano commented Jun 9, 2023 •
edited
Loading

There were some broken E2E tests in this PR:

We did not see them because the:

@da2ce7 da2ce7 deleted the 76-add-tags-to-torrents-new branch September 21, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josecelano josecelano josecelano approved these changes

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

No one assigned

Labels

Needs Rebase Base Branch has Incompatibilities

Projects

Torrust Solution
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tags to torrents

3 participants

@mickvandijke @josecelano