Skip to content

Refactor error handling for torrent upload #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2024
Merged

Refactor error handling for torrent upload #519

merged 2 commits into from
Mar 5, 2024

Conversation

@josecelano
Copy link
Member

@josecelano josecelano commented Mar 5, 2024 •
edited
Loading

  • Return a specific error when a user tries to upload a torrent with an original infohash that already exists.
  • Return 409 when a user tries to upload a torrent whose canonical or original infohash already exists (instead of 400).

@josecelano josecelano added this to the v3.0.0 milestone Mar 5, 2024
@josecelano josecelano linked an issue Mar 5, 2024 that may be closed by this pull request
Return a 409 Conflict status code when you try to upload a torrent whose canonical info-hash already exist #290
Closed
4 tasks
@josecelano josecelano added the - User - Enjoyable to Use our Software label Mar 5, 2024
@josecelano josecelano self-assigned this Mar 5, 2024
@josecelano
refactor: [torrust#290] return 4009 intead of 400 trying to upload du…
414d468 
…plicate torrents

Torrents with the same original or canonical infohash.
@josecelano
Copy link
Member Author

josecelano commented Mar 5, 2024

ACK 414d468

@josecelano josecelano marked this pull request as ready for review March 5, 2024 17:34
@josecelano josecelano merged commit f5cfc33 into torrust:develop Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

Assignees

@josecelano josecelano

Labels

- User - Enjoyable to Use our Software

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Return a 409 Conflict status code when you try to upload a torrent whose canonical info-hash already exist

1 participant

@josecelano