Skip to content

Conversation

@raincoats
Copy link

allows users to login to linux with facebook

allows users to login to linux with facebook
@immibis
Copy link

immibis commented Mar 18, 2014

Does it actually work?

@ghost
Copy link

ghost commented Mar 18, 2014

This looks amazing... :P

@enedil
Copy link

enedil commented Mar 18, 2014

And why would anyone want to use it?

@metemaddar
Copy link

Would you mind put the link of reference?
The link on the first discussion message got 404.

Thanks

On Tue, Mar 18, 2014 at 10:50 AM, enedil [email protected] wrote:

And why would anyone want to use it?

Reply to this email directly or view it on GitHubhttps://github.com//pull/81#issuecomment-37905283
.

Mohammad Etemaddar
http://goog_1283906581
metemaddar.ir
Web Development Services

@jesus-ramos
Copy link
Contributor

Should have at least started by putting the check inside of a function.

@ariccio
Copy link

ariccio commented Mar 22, 2014

Your other "joke" pull request made me laugh a bit. However, the linux kernel (particularly torvalds:master) isn't the place for this kind of humor.

@joshkurz
Copy link

yes @raincoats you should be banned for life...

@raincoats
Copy link
Author

@joshkurz lol u k

@IDM350
Copy link

IDM350 commented Mar 23, 2014

The code itself is useless. For one thing, you didn't even declare facebook_login_is_correct and what it is or does, you aren't working with Facebook at all in this code. Next up, facebook_login_is_correct can't be both a function and a boolean. You only broke it all. Then there's for (;;){sleep();}, which means sleep() will run and nothing else, and that is in the kernel which is responsible for what code is running at all times, so on ACCESS DENIED the computer just hangs and freezes.

Forget about that, Linux is only the kernel. Linux by itself does not have the user interface, the authentication control, or even the core system startup/service manager. Get out of this misconception that "Linux" is the whole operating system. You're modifying the Linux kernel, the part that goes in between to manage processes and drivers, applies contexts such as privileges and filesystem locations, and generally is responsible for what code is running at all times.

The correct form of what you're trying to achieve is actually a http://linux-pam.org/Linux-PAM-html/Linux-PAM_MWG.html module for logging in with Facebook, and maybe a GDM greeter which has a discrete "Login with Facebook" option, but this retarded try with the kernel should be closed.

@OrdinaryMagician
Copy link

Oh please, this isn't funny.

@raincoats
Copy link
Author

oh get over it stop clogging my emails

@clfarron4
Copy link

Is there any benefit to having this in kernel space instead of user-space?

@jomo
Copy link

jomo commented Sep 29, 2014

👍 we need this!

@github-staff github-staff deleted a comment Mar 26, 2025
@torvalds torvalds closed this Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.