-
Notifications
You must be signed in to change notification settings - Fork 58.2k
facebook functionality #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
allows users to login to linux with facebook
|
Does it actually work? |
|
This looks amazing... :P |
|
And why would anyone want to use it? |
|
Would you mind put the link of reference? Thanks On Tue, Mar 18, 2014 at 10:50 AM, enedil [email protected] wrote:
Mohammad Etemaddar |
|
Should have at least started by putting the check inside of a function. |
|
Your other "joke" pull request made me laugh a bit. However, the linux kernel (particularly torvalds:master) isn't the place for this kind of humor. |
|
yes @raincoats you should be banned for life... |
|
@joshkurz lol u k |
|
The code itself is useless. For one thing, you didn't even declare facebook_login_is_correct and what it is or does, you aren't working with Facebook at all in this code. Next up, facebook_login_is_correct can't be both a function and a boolean. You only broke it all. Then there's Forget about that, Linux is only the kernel. Linux by itself does not have the user interface, the authentication control, or even the core system startup/service manager. Get out of this misconception that "Linux" is the whole operating system. You're modifying the Linux kernel, the part that goes in between to manage processes and drivers, applies contexts such as privileges and filesystem locations, and generally is responsible for what code is running at all times. The correct form of what you're trying to achieve is actually a http://linux-pam.org/Linux-PAM-html/Linux-PAM_MWG.html module for logging in with Facebook, and maybe a GDM greeter which has a discrete "Login with Facebook" option, but this retarded try with the kernel should be closed. |
|
Oh please, this isn't funny. |
|
oh get over it stop clogging my emails |
|
Is there any benefit to having this in kernel space instead of user-space? |
|
👍 we need this! |
allows users to login to linux with facebook