Skip to content

Conversation

@mtrimolet
Copy link
Contributor

@mtrimolet mtrimolet commented Oct 26, 2020

What this PR does / why we need it:

Local references in referenced schemas were resolved relative to top level schema.
Expected behavior is to resolve them relative to referenced schema.

Types of changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes.

fixes #15

How Has This Been Tested?

test("should resolve nested references from their own context", async () => {

test("should properly resolve nested references", async () => {

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Local refs in refd schemas were resolved relative to top level schema.
Expected behavior is to resolve them relative to refd schema.

Refs: #15
@mtrimolet mtrimolet merged commit 9825a40 into master Oct 26, 2020
@mtrimolet mtrimolet deleted the @fix/nested-refs branch October 26, 2020 14:30
@mtrimolet mtrimolet restored the @fix/nested-refs branch October 26, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

References in referenced files not resolved

1 participant