Skip to content

Conversation

@paultiq
Copy link
Contributor

@paultiq paultiq commented Aug 13, 2025

While doing a little work testing 3.14/3.14t, added a few test cases to close a few uncovered branches:

The remaining gaps are for testing has_fnctl, which I'm not sure can ever occur on most OS's, since Windows already has a separate path for the Windows case.

Before

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/filelock/__init__.py      22      4      2      1    79%   41-44
src/filelock/_api.py         144      1     28      0    99%   237
src/filelock/_unix.py         38      2      4      0    95%   31-32
src/filelock/_util.py         19      0      4      1    96%   26->exit
src/filelock/asyncio.py      109      5     22      5    92%   86-87, 215->218, 229->232, 241-243, 260->exit
----------------------------------------------------------------------
TOTAL                       1038     12     82      7    98%

After

Name                       Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------
src/filelock/__init__.py      22      4      2      1    79%   41-44
src/filelock/_unix.py         38      2      4      0    95%   31-32
----------------------------------------------------------------------
TOTAL                       1115      6     84      1    99%

@paultiq paultiq requested a review from gaborbernat August 13, 2025 21:56
gaborbernat
gaborbernat previously approved these changes Aug 13, 2025
@gaborbernat gaborbernat enabled auto-merge (squash) August 13, 2025 22:15
@gaborbernat
Copy link
Member

@paultiq seems Windows is not happy 🤔

auto-merge was automatically disabled August 14, 2025 01:42

Head branch was pushed to by a user without write access

@paultiq
Copy link
Contributor Author

paultiq commented Aug 14, 2025

Windows seems happier now

@gaborbernat gaborbernat enabled auto-merge (squash) August 14, 2025 04:10
@gaborbernat gaborbernat merged commit 66a428e into tox-dev:main Aug 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants