Skip to content

Conversation

@dsklyar
Copy link
Contributor

@dsklyar dsklyar commented Nov 21, 2025

Description

New system Discovery UI uses updated backend, need to add ability for user to be able to export silo discovery result using CLI.

This PR implements pull functionality.

Based of #380 PR

Related Issues

Demo(s)

Added SD on local BE instance and executed CLI pointing to local

export TRANSCEND_API_URL=https://yo.com:4001
export NODE_EXTRA_CA_CERTS=../main/ssl/ca-crt.pem
export TRANSCEND_API_KEY=UAZjiGVC506obunh1u*uPMhdpcsxDX+kHrV2Br287ephvob6
pnpm start inventory pull --auth 'API_KEY_FOR_LOCAL_BACKEND'

Result

siloDiscoveryResults
  - title: aurora-mysql - test-aurora-db-instance-1 - 207539467107:eu-west-1
    resourceId: arn:aws:rds:eu-west-1:207539467107:db:test-aurora-db-instance-1
    suggestedCatalog: Amazon Aurora
    plugin: Amazon Web Services (AWS)
    country: IE
    plaintextContext: |-
      {
        "role": "AWSDataSiloDiscoveryPluginDev",
        "region": "eu-west-1",
        "username": "",
        "accountId": "207539467107",
        "pluginsToAutoEnable": "",
        "endpoint": "test-aurora-db-instance-1.cjstlfqxusgf.eu-west-1.rds.amazonaws.com",
        "port": "3306",
        "driver": "MySQL"
      }
    containsSensitiveData: LIKELY

@linear
Copy link

linear bot commented Nov 21, 2025

Copy link
Member

@michaelfarrell76 michaelfarrell76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sik

Copy link
Contributor

@blevine-transcend blevine-transcend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! do we want to include or filter on status? potentially good to know, as i believe these results will include ones already to added to inventory

@dsklyar
Copy link
Contributor Author

dsklyar commented Nov 21, 2025

sweet! do we want to include or filter on status? potentially good to know, as i believe these results will include ones already to added to inventory

Ah yeah you are right, adding status makes sense here! I am not sure how to add a filter just yet, but will amend this PR to add status for now.

@dsklyar dsklyar merged commit 3a2afb4 into main Nov 21, 2025
11 checks passed
@dsklyar dsklyar deleted the link-5243-add-SiloDiscoveryResults-export branch November 21, 2025 21:26
@@ -0,0 +1,19 @@
siloDiscoveryResults:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh crap i missed this, i think our top level keys are in dash case, can we change to just system-discovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants